Skip to content

fix: restore legacy suffix compatibility#2100

Open
zeitlinger wants to merge 1 commit intoprometheus:mainfrom
zeitlinger:fix/legacy-gauge-family-name
Open

fix: restore legacy suffix compatibility#2100
zeitlinger wants to merge 1 commit intoprometheus:mainfrom
zeitlinger:fix/legacy-gauge-family-name

Conversation

@zeitlinger
Copy link
Copy Markdown
Member

@zeitlinger zeitlinger commented May 5, 2026

Fixes #2095

Summary

Restores OM1/protobuf compatibility for dotted gauge names after
feat: move suffix handling to scrape time (#1955).

The bug was that non-OpenMetrics exposition changed visible output for gauge
names that merely ended in suffix-like dotted strings such as .created and
.total.

Examples:

  • Gauge("test3.created") regressed from test3 to test3_created
  • Gauge("test6.total") regressed from test6 to test6_total

This PR restores the legacy OM1/protobuf behavior while keeping OpenMetrics on
literal-name handling.

This is the extracted prom-side fix from #2093. The Micrometer workflow and
related downstream testing were split into a stacked follow-up PR so this can
merge independently.

What changed

  • Fix OM1 text exposition for dotted gauge names ending in .created and
    .total
  • Fix protobuf exposition for the same compatibility cases
  • Add regression tests that cover the restored OM1/protobuf behavior and the
    preserved OpenMetrics behavior
  • Clean up protobuf family-name resolution so legacy gauge handling lives in
    one path instead of pre-rewriting metadata objects

Follow-up stacked PR

Related

Testing

  • mise run build
  • mise run lint
  • ./mvnw test -pl prometheus-metrics-exposition-textformats,prometheus-metrics-exposition-formats -Dtest=ExpositionFormatsTest,ProtobufExpositionFormatsTest,DuplicateNamesProtobufTest -Dcoverage.skip=true -Dcheckstyle.skip=true

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: restore OM1/protobuf suffix compatibility after #1955

1 participant